NFC: remove dead external validation code paths from dxcompiler#7451
Merged
bob80905 merged 16 commits intomicrosoft:mainfrom Jun 5, 2025
Merged
NFC: remove dead external validation code paths from dxcompiler#7451bob80905 merged 16 commits intomicrosoft:mainfrom
bob80905 merged 16 commits intomicrosoft:mainfrom
Conversation
Contributor
|
✅ With the latest revision this PR passed the C/C++ code formatter. |
tex3d
reviewed
May 15, 2025
tex3d
reviewed
May 15, 2025
tex3d
reviewed
May 15, 2025
tex3d
reviewed
May 15, 2025
tex3d
reviewed
May 15, 2025
tex3d
reviewed
May 15, 2025
tex3d
reviewed
May 15, 2025
tex3d
reviewed
May 15, 2025
tex3d
reviewed
May 15, 2025
tex3d
reviewed
May 15, 2025
tex3d
reviewed
May 15, 2025
tex3d
reviewed
May 19, 2025
tex3d
reviewed
May 19, 2025
tex3d
reviewed
May 19, 2025
tex3d
reviewed
May 19, 2025
tex3d
reviewed
May 20, 2025
bob80905
changed the title
bob80905
changed the title
tex3d
reviewed
May 20, 2025
tex3d
reviewed
May 20, 2025
tex3d
reviewed
May 20, 2025
tex3d
approved these changes
May 20, 2025
Contributor
There was a problem hiding this comment.
Looks good, but the title should probably be revised so it doesn't need to be interpreted within the context of a broader work item to understand what it means. And update the description to describe the change.
Perhaps something like this for the title:
NFC: remove dead external validation code paths from dxcompiler
30b3914 to
733ce1e
Compare
bob80905
force-pushed
the
add_dxil_dll_path_opt
branch
from
733ce1e to
44c2c67
Compare
spall
approved these changes
Jun 5, 2025
Collaborator
spall
left a comment
spall
left a comment
There was a problem hiding this comment.
LGTM from my understanding level
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DXC has now been changed to use the internal validator (loaded by dxcompiler.dll) by default. This PR removes the ability for dxc.exe to load dxil.dll in preparation for a series of changes to fix external validation handling.
Fixes #7525